Skip to content

Conversation

andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Oct 2, 2025

Also fixed a dodgy heading in the strings page.

Staging for hashes: https://redis.io/docs/staging/DOC-5790-rust-dt-tces/develop/data-types/hashes/

@andy-stark-redis andy-stark-redis requested a review from a team October 2, 2025 14:54
@andy-stark-redis andy-stark-redis added the clients Client library docs label Oct 2, 2025
Copy link
Contributor

github-actions bot commented Oct 2, 2025

DOC-5790

Copy link
Contributor

github-actions bot commented Oct 2, 2025

Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't scrutinize the examples. I do have one thought: there are already two directories for rust examples:

local_examples/client-specific/rust-async
local_examples/client-specific/rust-sync

Maybe put these new examples there instead of under local_examples?

Up to you.

@andy-stark-redis
Copy link
Contributor Author

I didn't scrutinize the examples. I do have one thought: there are already two directories for rust examples:

@dwdougherty The distinction is that the client-specific files are for the pages in the client folders requested by Mirko (eg, redis-py has an Index and query documents page with just Python examples, but other clients have similar pages). TBH, I don't know if it's worth making the distinction - I just started doing it like that and this is just a continuation :-) Could maybe consolidate the examples together in a future PR.

@andy-stark-redis
Copy link
Contributor Author

Anyway, thanks for the review @dwdougherty !

@andy-stark-redis andy-stark-redis merged commit d6ff9e7 into main Oct 2, 2025
9 checks passed
@andy-stark-redis andy-stark-redis deleted the DOC-5790-rust-dt-tces branch October 2, 2025 15:12
@dwdougherty
Copy link
Collaborator

Ah... okay. As you were. 🫠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clients Client library docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants