Skip to content

Conversation

WTIFS
Copy link
Contributor

@WTIFS WTIFS commented Nov 12, 2019

In function cmdInfo(name string), we use lower cmd name to find the cmdsInfo.

//name is lower case
func (c *Ring) cmdInfo(name string) *CommandInfo {
	cmdsInfo, err := c.cmdsInfoCache.Get()
	if err != nil {
		return nil
	}
	info := cmdsInfo[name]
	if info == nil {
		internal.Logger.Printf("info for cmd=%s not found", name)
	}
	return info
}

But for extensions like bloom filter, the "command" returns names with uppercase.

I think if we use lowercase name to find the cmdInfo, then we should turn cmd names to lower case when we fill the cmdsInfoCache.

@vmihailenco vmihailenco merged commit eb64034 into redis:master Nov 19, 2019
@vmihailenco
Copy link
Collaborator

Thanks

vmihailenco added a commit that referenced this pull request Mar 11, 2020
Set key to lowercase in cmdsInfoCache.Get()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants