Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support redis.RESP3 protocol #1716

Closed
wants to merge 10 commits into from
Closed

Support redis.RESP3 protocol #1716

wants to merge 10 commits into from

Conversation

monkey92t
Copy link
Collaborator

No description provided.

Signed-off-by: monkey <golang@88.com>
Signed-off-by: monkey <golang@88.com>
Signed-off-by: monkey <golang@88.com>
Signed-off-by: monkey <golang@88.com>
Signed-off-by: monkey <golang@88.com>
Signed-off-by: monkey <golang@88.com>
Signed-off-by: monkey <golang@88.com>
Signed-off-by: monkey <golang@88.com>
Signed-off-by: monkey <golang@88.com>
Signed-off-by: monkey <golang@88.com>
@monkey92t monkey92t closed this Apr 6, 2021
@vmihailenco
Copy link
Collaborator

Let me know if you need any help with design. My first impression is that pvs []*proto.Value going to be slow since we need to allocate an intermediate value before scanning the result. Reading directly into the dest variable is much more efficient...

@monkey92t
Copy link
Collaborator Author

Yes, I found the problem, I need to redesign it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants