Skip to content

feat: add WriteArg net.IP #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2022
Merged

feat: add WriteArg net.IP #2062

merged 2 commits into from
Mar 28, 2022

Conversation

zuoshuwen
Copy link
Contributor

No description provided.

@zuoshuwen
Copy link
Contributor Author

#2061

@vmihailenco
Copy link
Collaborator

Please add an end-to-end test that IP can be scanned back using rdb.Get(ctx, "key").Scan(&ip).

@zuoshuwen
Copy link
Contributor Author

Sorry, did I understand it right?

monkey92t
monkey92t approved these changes Mar 28, 2022
View reviewed changes
@monkey92t
Copy link
Collaborator

Later I try to add more interfaces.

@monkey92t monkey92t merged commit 7d5167e into redis:master Mar 28, 2022
@monkey92t
Copy link
Collaborator

Thanks~

@monkey92t monkey92t mentioned this pull request Mar 28, 2022
Closed
@zuoshuwen
Copy link
Contributor Author

Thanks for taking this PR :)

evilaffliction pushed a commit to reactive-go/redis that referenced this pull request Jun 15, 2022
@zuoshuwen @evilaffliction
feat: add WriteArg and Scan net.IP(redis#2062)
7893401 
* feat: add WriteArg net.IP

* feat: add Scan net.IP
evilaffliction pushed a commit to reactive-go/redis that referenced this pull request Jun 15, 2022
@zuoshuwen @evilaffliction
feat: add WriteArg and Scan net.IP(redis#2062)
b49e2e8 
* feat: add WriteArg net.IP

* feat: add Scan net.IP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@monkey92t monkey92t monkey92t approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zuoshuwen @vmihailenco @monkey92t