Add support for filtering traces for certain commands #3519
+171
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
Sovietaced
changed the title
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
|
Hello @Sovietaced and thank you for your contribution. Maybe @vmihailenco can take a look at this. If he doesn't I will around the end of the month. |
ndyakov
approved these changes
Sep 17, 2025
|
@Sovietaced I can see we have #3481 opened as well, I personally prefer the filtering approach in this PR, but let's discuss with @vmihailenco. @htemelski-redis feel free to decide which one you prefer when you are back from vacation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3516
redisotelcan generate traces for Redis commands that include sensitive data (ie. hello command). There currently exists an option to disable thedb.statementattribute in traces but this is a global setting.This pull request adds support for a configurable command filter that will omit traces for commands that filter returns true for. It also adds a basic command filter to filter out sensitive data by default which I feel like should be the correct behavior to prevent security incidents.