Skip to content

Conversation

vchomakov
Copy link
Contributor

Summary

Fixes validation of Redis URL parameter to properly handle whitespace-only values. Previously, URLs containing only whitespace characters would pass validation but cause parsing errors.

Changes

  • Added url.strip() check in CLI URL validation
  • Prevents processing of empty or whitespace-only URLs
  • Maintains existing behavior for valid URLs

Testing

  • Tested with empty string URL
  • Tested with whitespace-only URL (" ", "\n\t")
  • Tested with valid URLs (no regression)
  • Existing tests pass

Example

# Before: Would cause parsing error
redis-mcp-server --url "   "

# After: Gracefully skips invalid URL and uses defaults
redis-mcp-server --url "   "

@vchomakov vchomakov self-assigned this Oct 8, 2025
Copy link
Contributor

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vchomakov vchomakov merged commit 7cf6604 into main Oct 8, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants