.toLowerCase is slow

[dcharbonnier]

According to this http://jsperf.com/regex-vs-tolowercase toLowerCase is slow.
My test consist on doing 1000 multi each containing 100 sadd (real use-case for me).
Replacing toLowerCase with regexp increase performance by 5%, removing possibility of uppercase (using === string with no uppercase alternative) increase performance by 10%. Is there any good reason for allowing different case for functions ? When people use redis most of the time performance is critical.

[dirkbonhomme]

I normally would dismiss this for being too much of an optimization but for Redis you might have a solid argument. +1

[brycebaril]

While I agree that the original design of allowing for the upper-case commands may have been unnecessary, it is unlikely to change in the short term.

As for the expense of toLowerCase I would be very surprised if the results you were seeing were actually due to the toLowerCase or just the variations you get when doing benchmarks. Even though it is "slow" toLowerCase gets about 700,000 operations per second in your jsperf. If the browser numbers are a reasonable estimate for Node, with 100,000 toLowerCase calls in your test it should add milliseconds to the total runtime.

[blainsmith]

In order to better support this project and its new group of collaborators under a new org we are trying to clean up and close issues older than 6 months. Your issue may have been fixed since the issue was open, however, if you are still experiencing a problem please re-open this issue and we will label it accordingly.

[BridgeAR]

Reopened as the issue is still present but going to be fixed soon