Convert snake_case options to camelCase before sending into tls || net (FIXES #1103)

[ghost]

Convert snake_case options to camelCase before sending into tls || net (FIXES #1103)

[BridgeAR]

This is going to run on every reconnect attempt. Instead, the fix could be placed where the options are converted to camel_case. That would only run once for each client. The clone function could receive a extra argument to skip the converting tls options to camel_case and special handle that by checking if the key name is tls.

[ghost]

I don't understand the sacred meaning of conversion to snake_case so I wrote my code right before sending connection options into tls or net, the same way it was converted. Sorry, this code is not in my style. May be this quest is for the person who has implemented the conversion. Do it as you see fit please.

[BridgeAR]

The reason for the conversion is that node_redis was written in snake_case and camelCase support was added by converting these values to snake_case and therefore both is supported.

[ghost]

In my opinion the solution is to leave connection_options as is, I mean do not clone it.
Instead of:

function RedisClient (options, stream) {
    // Copy the options so they are not mutated
    options = utils.clone(options);
    EventEmitter.call(this);
    var cnx_options = {};
    ...
}

Something like:

function RedisClient (options, stream) {    
    EventEmitter.call(this);
    var cnx_options = {};
    ...
    // Copy the options so they are not mutated
    options = utils.clone(options);
    ...
}

[BridgeAR]

The options are already cloned before they are passed to the constructor. This is done in the createClient function.

[BridgeAR]

@DaB00 thanks a lot for your contribution! And sorry it took so long...