Skip to content

Conversation

kpx-dev
Copy link
Contributor

@kpx-dev kpx-dev commented Apr 27, 2017

solve #1000

Copy link
Contributor

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit, LGTM otherwise.

Thanks for the PR!

README.md Outdated

```js
// this key will expires after 10 seconds
client.setex('myKey', 10, 'Awesome value!');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documenting the set command would likely be better as there were a couple of questions about the structure of
SET key value [EX seconds] [PX milliseconds] [NX|XX].
So writing:

client.set('key', 'value!', 'EX', 10);

would be better.

@kpx-dev
Copy link
Contributor Author

kpx-dev commented Apr 27, 2017

@BridgeAR cool updated PR.

Copy link
Contributor

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants