Skip to content

Add the list of removed events to migration guide #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 13, 2022
Merged

Add the list of removed events to migration guide #1761

merged 5 commits into from
Jan 13, 2022

Conversation

AnnAngela
Copy link
Contributor

Description

Add the list of removed events to migration guide, and improve the readability of the event table in readme.md

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

The PR only changes some documents.

simonprickett
simonprickett approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@simonprickett simonprickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of suggestions but looks good to me.

AnnAngela and others added 2 commits January 12, 2022 09:04
@AnnAngela @simonprickett
Update docs/v3-to-v4.md
c279159 
Co-authored-by: Simon Prickett <simon@crudworks.org>
@AnnAngela @simonprickett
Update docs/v3-to-v4.md
ea80eef 
Co-authored-by: Simon Prickett <simon@crudworks.org>
@AnnAngela
Copy link
Contributor Author

@simonprickett THX a lot! I merged the changes.

@leibale leibale merged commit 9516b88 into redis:master Jan 13, 2022
florian-schunk pushed a commit to florian-schunk/node-redis that referenced this pull request Jun 18, 2025
@AnnAngela @simonprickett
Add the list of removed events to migration guide (redis#1761)
071b177 
* Update v3-to-v4.md

* Update README.md

* Correct the wrong description

* Update docs/v3-to-v4.md

Co-authored-by: Simon Prickett <simon@crudworks.org>

* Update docs/v3-to-v4.md

Co-authored-by: Simon Prickett <simon@crudworks.org>

Co-authored-by: Simon Prickett <simon@crudworks.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guyroyse guyroyse guyroyse approved these changes

+2 more reviewers

@simonprickett simonprickett simonprickett approved these changes

@sahilarorafzr sahilarorafzr sahilarorafzr approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AnnAngela @simonprickett @guyroyse @sahilarorafzr @leibale