Add streams XREADGROUP and XACK example. #1832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1832 +/- ##
=======================================
Coverage 95.05% 95.05%
=======================================
Files 353 353
Lines 3314 3314
Branches 407 407
=======================================
Hits 3150 3150
Misses 81 81
Partials 83 83 Continue to review full report at Codecov.
|
leibale
reviewed
Jan 15, 2022
| @@ -6,7 +6,6 @@ async function streamProducer() { | |||
| const client = createClient(); | |||
|
|
|||
| await client.connect(); | |||
| await client.del('mystream'); | |||
There was a problem hiding this comment.
@leibale I removed the del because this makes this example work better with the consumer group one... if this deletes the stream it will delete any associated consumer groups too and then if they're running the consumer group example and it runs out of entries to process then they start the producer again it will blow away the stream rather than just continue to add new entries to it.
leibale
reviewed
Jan 15, 2022
| MKSTREAM: true | ||
| }); | ||
| console.log('Created consumer group.'); | ||
| } catch (e) { |
leibale
approved these changes
Jan 19, 2022
florian-schunk
pushed a commit
to florian-schunk/node-redis
that referenced
this pull request
Jun 18, 2025
* Removed stream delete command to allow consumer group example to work. * Adds stream consumer group example. * Adds stream consumer group example code. * Update README.md Co-authored-by: Leibale Eidelman <leibale1998@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a stream consumer group example that uses
XREADGROUPandXACK.Closes #1831
Checklist
npm testpass with this change (including linting)?