Add command timeout #3008
Merged
Add command timeout #3008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelPashov
approved these changes
Jul 4, 2025
bobymicroby
approved these changes
Jul 7, 2025
Co-authored-by: Florian Schunk <149071178+florian-schunk@users.noreply.github.com>
nkaradzhov
force-pushed
the
add-command-timeout
branch
from
1ee604b to
25ce9b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add command timeout in the command options. It can be set via the global options when creating a client or per command when using the generic
sendCommandfunctionTimeout only works while the command is still pending to be sent. Once a command is sent over the wire, the timeout is deleted and is never going to trigger. This decision could be changed if we deem its not good enough
Checklist
npm testpass with this change (including linting)?