Skip to content

test(maint): touch up wrong assertions #3096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
Merged

test(maint): touch up wrong assertions #3096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/client/lib/tests/test-scenario/timeout-during-notifications.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ describe("Timeout Handling During Notifications", () => {
"Command Timeout error should be instanceof Error"
);
assert.ok(
duration > NORMAL_COMMAND_TIMEOUT &&
duration < NORMAL_COMMAND_TIMEOUT * 1.1,
duration >= NORMAL_COMMAND_TIMEOUT &&
duration < NORMAL_COMMAND_TIMEOUT * 1.2,
`Normal command should timeout within normal timeout ms`
);
assert.strictEqual(
Expand Down Expand Up @@ -128,8 +128,8 @@ describe("Timeout Handling During Notifications", () => {
`${notification} notification error should be instanceof Error`
);
assert.ok(
result[notification]?.duration > RELAXED_COMMAND_TIMEOUT &&
result[notification]?.duration < RELAXED_COMMAND_TIMEOUT * 1.1,
result[notification]?.duration >= RELAXED_COMMAND_TIMEOUT &&
result[notification]?.duration < RELAXED_COMMAND_TIMEOUT * 1.2,
`${notification} notification should timeout within relaxed timeout`
);
assert.strictEqual(
Expand Down Expand Up @@ -165,7 +165,7 @@ describe("Timeout Handling During Notifications", () => {
);
assert.ok(
durationMigrate >= NORMAL_COMMAND_TIMEOUT &&
durationMigrate < NORMAL_COMMAND_TIMEOUT * 1.1,
durationMigrate < NORMAL_COMMAND_TIMEOUT * 1.2,
`Normal command should timeout within normal timeout ms`
);
assert.strictEqual(
Expand Down Expand Up @@ -200,7 +200,7 @@ describe("Timeout Handling During Notifications", () => {
);
assert.ok(
durationBind >= NORMAL_COMMAND_TIMEOUT &&
durationBind < NORMAL_COMMAND_TIMEOUT * 1.1,
durationBind < NORMAL_COMMAND_TIMEOUT * 1.2,
`Normal command should timeout within normal timeout ms`
);
assert.strictEqual(
Expand Down
8 changes: 4 additions & 4 deletions packages/client/lib/tests/test-scenario/to-failover.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ describe("Timeout Handling During Notifications", () => {
`${notification} notification error should be instanceof Error`
);
assert.ok(
result[notification]?.duration > RELAXED_COMMAND_TIMEOUT &&
result[notification]?.duration < RELAXED_COMMAND_TIMEOUT * 1.1,
result[notification]?.duration >= RELAXED_COMMAND_TIMEOUT &&
result[notification]?.duration < RELAXED_COMMAND_TIMEOUT * 1.2,
`${notification} notification should timeout within relaxed timeout`
);
assert.strictEqual(
Expand Down Expand Up @@ -138,8 +138,8 @@ describe("Timeout Handling During Notifications", () => {
"Command Timeout error should be instanceof Error"
);
assert.ok(
duration > NORMAL_COMMAND_TIMEOUT &&
duration < NORMAL_COMMAND_TIMEOUT * 1.1,
duration >= NORMAL_COMMAND_TIMEOUT &&
duration < NORMAL_COMMAND_TIMEOUT * 1.2,
`Normal command should timeout within normal timeout ms`
);
assert.strictEqual(
Expand Down
Loading