-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add latency histogram #3099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add latency histogram #3099
Conversation
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @NaughtySora, thanks again for the contribution! There are couple of issues, i have created a PR to your branch with fixes.
- Add some tests for RESP3
- Change histogram_usec to be a map
Hi, thank you so much for the amends. |
I'm i right to assume that according to the redis documentation i need also implement RESP 2 transform function with histogram usec tuple? |
Adding LATENCY HISTOGRAM command.
I personally will use this in my current and future projects.
#1955
I have tried to run all the tests locally but facing the same issue with timeout as before.
npm test
pass with this change (including linting)?Tests are present.
I think documentation about commands located in redis official website.