Skip to content

Features/hash object #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Sep 17, 2010
Merged

Features/hash object #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b3a1c3
Added HGETALL object assertions
tj Sep 17, 2010
bcbf383
Implemented HGETALL response as object
tj Sep 17, 2010
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,16 @@ RedisClient.prototype.return_reply = function (reply_buffer) {
var command_obj = this.command_queue.shift();

if (command_obj && typeof command_obj.callback === "function") {
// HGETALL special case replies with keyed Buffers
if ('HGETALL' == command_obj.command) {
var obj = {};
for (var i = 0, len = reply_buffer.length; i < len; ++i) {
var key = reply_buffer[i].toString(),
val = reply_buffer[++i];
obj[key] = val;
}
reply_buffer = obj;
}
command_obj.callback(null, reply_buffer);
} else {
if (this.debug_mode) {
Expand Down
14 changes: 6 additions & 8 deletions test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,15 +353,13 @@ tests.MULTI = function () {
tests.HGETALL = function () {
var name = "HGETALL";
client.hmset(["hosts", "mjr", "1", "another", "23", "home", "1234"], require_string("OK", name));
client.HGETALL(["hosts"], function (err, results) {
client.HGETALL(["hosts"], function (err, obj) {
assert.strictEqual(null, err, name + " result sent back unexpected error");
assert.strictEqual(6, results.length, name);
assert.strictEqual("mjr", results[0].toString(), name);
assert.strictEqual("1", results[1].toString(), name);
assert.strictEqual("another", results[2].toString(), name);
assert.strictEqual("23", results[3].toString(), name);
assert.strictEqual("home", results[4].toString(), name);
assert.strictEqual("1234", results[5].toString(), name);
assert.strictEqual(3, Object.keys(obj).length, name);
assert.ok(Buffer.isBuffer(obj.mjr), name);
assert.strictEqual("1", obj.mjr.toString(), name);
assert.strictEqual("23", obj.another.toString(), name);
assert.strictEqual("1234", obj.home.toString(), name);
next(name);
});
};
Expand Down