Improving server_info

[SinisterLight]

Improving server_info object by parsing the db* keys of redis-info.
earlier it was
server_info = { ..
db0: 'keys=1,expires=0,avg_ttl=0',
db9: 'keys=49,expires=49,avg_ttl=2588996447',
.. }
changed this to
server_info = { ..
db0: { keys: '1', expires: '0', avg_ttl: '0' },
db9: { keys: '49', expires: '49', avg_ttl: '2588996447' }
..}

[brycebaril]

Pondering the performance implications.

One downside is that even though in most long-lived connections (normal use case) it will be very apparent in the benchmarks, which call INFO a lot (INFO is called on every connection)

[BridgeAR]

@brycebaril I doubt that this is going to impact the performance in a measurable way as there are only very few lines that will be parsed in the special way (most of the time it'll just be one). It might be a very tiny speed improvement to only iterate over the keyspace part e.g.

var i = 0;
var key = 'db' + i;
while (obj[key]) {
  var sublines = obj[key].split(',');
  // do stuff with the keyspace ...
  i++;
  key = 'db' + i;
}

And we could improve the performance of the info call further by removing the .forEach. That of course, is independent from this merge request.
So I'd say this is fine if it's going to be rebased, but I do not have a strong opinion about this.

[BridgeAR]

Git got fixed by #855

Thx @SinisterLight