Update commands list and remove unecessary code #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Superseds #702 |
|
@BridgeAR good job. It's cool to see those cluster commands coming in, it would be neat to put a test or two around those to get a feel for the API. |
|
@bcoe cluster was already supported, but I'm uncertain if it works. So we should definitely add some tests but I guess that could be done in a separate PR? |
| } | ||
|
|
||
| if (Array.isArray(args)) { |
There was a problem hiding this comment.
args is always an array
Add use strict Add changelog entry
BridgeAR
added a commit
that referenced
this pull request
Sep 12, 2015
Update commands list and remove unecessary code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code is not necessary at all and can safely be removed. There were only a few very old redis commands that we should probably not support anymore.
Support is dropped for:
New commands supported are:
The new commands have no tests yet, but I'd say this is good to go right away and we should add some tests for this later on.