minor tweaks to how we spawn tests in #815 #819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (options.retry_max_delay !== undefined && !isNaN(options.retry_max_delay) && options.retry_max_delay > 0) { | ||
| this.retry_max_delay = options.retry_max_delay; | ||
| if (options.retry_max_delay && options.retry_max_delay > 0) { | ||
| this.retry_max_delay = +options.retry_max_delay; |
There was a problem hiding this comment.
@BridgeAR this change concerns me a bit, why the pre-increment? and should we still confirm that options.retry_max_delay is a #?
There was a problem hiding this comment.
The + is only a type coercion to number :)
a > 0 is also doing a type coercion, so it'll be the same as it was before
bcoe
added a commit
that referenced
this pull request
Sep 12, 2015
minor tweaks to how we spawn tests in #815
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slight modification to #815
:6379.