2.5 #998
Merged
2.5 #998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 28 commits
March 1, 2016 17:59
This will also clone functions
The reply is being done with a regular array and therefor will be the same array instance
This benchmark should not be relied on. v8 is going to inline code and the benchmark expactations won't be met anymore
Add execution order tests Fix flaky test Add utils tests Improve other tests
Removed redundant tests. Skip the tests on windows instead of not even showing them. Add a faulty cert to check proper cert validation. Reject unauthorized certs
…nimum Also pass individual ports to the redis process through
Don't write "Error:" infront of errors
… smaller ones Also refactor small stuff here Removed the .send_anyway boolean and use .ready instead
Skip redis process spawn on windows for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a version that took quite a while, since I wanted to deprecate a couple of things before landing it and polishing a couple of smaller things.
This should be ready now. As there are substantial changes, this will be released as a pre-release.
On Windows the redis process does not spawn properly but this did not work earlier either, so this should be fixed in another PR.