Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for password-encrypted SSL private keys #1782

Merged
merged 12 commits into from
Dec 16, 2021

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Dec 9, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #1767
closes #1757

@chayim chayim added the feature New feature label Dec 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #1782 (59c44cc) into master (f82ab33) will increase coverage by 0.09%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1782      +/-   ##
==========================================
+ Coverage   94.22%   94.31%   +0.09%     
==========================================
  Files          74       75       +1     
  Lines       15681    15721      +40     
==========================================
+ Hits        14776    14828      +52     
+ Misses        905      893      -12     
Impacted Files Coverage Δ
redis/client.py 89.96% <ø> (+0.11%) ⬆️
tests/conftest.py 91.13% <66.66%> (-0.75%) ⬇️
redis/connection.py 88.51% <100.00%> (+1.19%) ⬆️
tests/test_ssl.py 100.00% <100.00%> (ø)
tests/test_cluster.py 98.79% <0.00%> (+0.12%) ⬆️
redis/utils.py 90.32% <0.00%> (+6.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f82ab33...59c44cc. Read the comment docs.

@chayim chayim merged commit 18c6809 into redis:master Dec 16, 2021
@chayim chayim deleted the ck-ssl-cert-passwords branch December 16, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SSL Environments for Testing Enhancement Request: Support for encrypted SSL private keys
2 participants