Add support for BZMPOP #1851

dvora-h · 2022-01-04T10:53:42Z

Pull Request check-list

Please make sure to review and check all of these items:

Does $ tox pass with this change (including linting)?
Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
Is the new or changed code fully tested?
Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #1800

chayim

Same SINTERCARD PR changes.

codecov-commenter · 2022-01-12T14:27:37Z

Codecov Report

Merging #1851 (dbc342c) into master (15f315a) will decrease coverage by 0.55%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1851      +/-   ##
==========================================
- Coverage   93.60%   93.04%   -0.56%     
==========================================
  Files          76       76              
  Lines       16214    16446     +232     
==========================================
+ Hits        15177    15303     +126     
- Misses       1037     1143     +106

Impacted Files	Coverage Δ
redis/commands/core.py	`89.99% <100.00%> (+0.05%)`	⬆️
tests/test_commands.py	`99.39% <100.00%> (+<0.01%)`	⬆️
tests/test_ssl.py	`48.46% <0.00%> (-5.67%)`	⬇️
redis/connection.py	`87.02% <0.00%> (-1.31%)`	⬇️
tests/test_cluster.py	`98.41% <0.00%> (-0.13%)`	⬇️
redis/ocsp.py	`0.00% <0.00%> (ø)`
redis/retry.py	`100.00% <0.00%> (ø)`
redis/client.py	`89.37% <0.00%> (ø)`
tests/test_search.py	`99.07% <0.00%> (+0.05%)`	⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15f315a...dbc342c. Read the comment docs.

chayim · 2022-01-24T07:08:06Z

redis/commands/core.py

+    def bzmpop(
+        self,
+        timeout: float,
+        num_keys: int,


num_keys should probably be numkeys - given the help text

chayim · 2022-01-24T07:08:41Z

redis/commands/core.py

+        """
+        args = [timeout, num_keys, *keys]
+        if (min and max) or (not min and not max):
+            raise DataError


raise DataError('Either min or max, but not both must be set')```

chayim · 2022-01-24T07:16:03Z

redis/commands/core.py

+            args.append("MIN")
+        else:
+            args.append("MAX")
+        if count != 1:


Any reason to not extend either way? We can save the cost of this if check - so it's cheaper. Though, it's unclear if there's a default. What does redis-cli say?

In redis-cli if you don't specify the count it will pop 1, so I changhed it to extend either way.

* add bzmpop * add comment * fix pr comment * fix linters * fix pr comments

* add redis5 and redis4 dockers * redis versions testenv * path changes * fix linters * fix tests * fixing linter * Increased pubsub's wait_for_messages timeout to prevent flaky tests (#1893) * Fixing TypeError in GraphCommands.explain (#1901) * Fixing AttributeError in UnixDomainSocketConnection (#1903) * Fixing AttributeError on some connection errors (#1905) * cluster script fixes to support future cluster versions and redis unstable (#1900) * Fixing LMOVE, BLMOVE returning an incorrect response (#1906) * Raising ConnectionError on invalid ocsp certificates - with status information (#1907) * 4.1.2 (#1904) * adding cluster env timeout time (#1908) * Update changes file with changes since 4.0.0-beta2 (#1915) * Fixing volume for unstable_cluster docker (#1914) * Change json.clear test multi to be up to date with redisjson (#1922) * fix json clear test * fix json clear test * Add support for BZMPOP (#1851) * add bzmpop * add comment * fix pr comment * fix linters * fix pr comments * add client no-evict (#1856) * Add support for ZINTERCARD (#1857) * add zintercard * fix pr comment * linters * Add support for EVAL_RO (#1862) * add sort_ro * mark test as onlynon cluster * delete mark test as onlynoncluster * add eval_ro * fix linters * delete sort_ro * fix pr comment * add type hints * add type hints * linters * Add support for EVALSHA_RO (#1863) * add evalsha-ro * fix pr comment * add type hints * add type hints * Fix naming conventions (#1872) * fix naming convention * fix worng changes * change ports to resolve conflict with unstable_cluster Co-authored-by: Chayim I. Kirshen <c@kirshen.com> Co-authored-by: Chayim <chayim@users.noreply.github.com> Co-authored-by: Bar Shaul <88437685+barshaul@users.noreply.github.com> Co-authored-by: Varun Chopra <v@chopraaa.com>

* add type hints for json commands * Change json.clear test multi to be up to date with redisjson (#1922) * fix json clear test * fix json clear test * Add support for BZMPOP (#1851) * add bzmpop * add comment * fix pr comment * fix linters * fix pr comments * add client no-evict (#1856) * Add support for ZINTERCARD (#1857) * add zintercard * fix pr comment * linters * Add support for EVAL_RO (#1862) * add sort_ro * mark test as onlynon cluster * delete mark test as onlynoncluster * add eval_ro * fix linters * delete sort_ro * fix pr comment * add type hints * add type hints * linters * Add support for EVALSHA_RO (#1863) * add evalsha-ro * fix pr comment * add type hints * add type hints * Fix naming conventions (#1872) * fix naming convention * fix worng changes * fix naming convention in rootPath

* add redis5 and redis4 dockers * redis versions testenv * path changes * fix linters * fix tests * fixing linter * Increased pubsub's wait_for_messages timeout to prevent flaky tests (#1893) * Fixing TypeError in GraphCommands.explain (#1901) * Fixing AttributeError in UnixDomainSocketConnection (#1903) * Fixing AttributeError on some connection errors (#1905) * cluster script fixes to support future cluster versions and redis unstable (#1900) * Fixing LMOVE, BLMOVE returning an incorrect response (#1906) * Raising ConnectionError on invalid ocsp certificates - with status information (#1907) * 4.1.2 (#1904) * adding cluster env timeout time (#1908) * Update changes file with changes since 4.0.0-beta2 (#1915) * Fixing volume for unstable_cluster docker (#1914) * Change json.clear test multi to be up to date with redisjson (#1922) * fix json clear test * fix json clear test * Add support for BZMPOP (#1851) * add bzmpop * add comment * fix pr comment * fix linters * fix pr comments * add client no-evict (#1856) * Add support for ZINTERCARD (#1857) * add zintercard * fix pr comment * linters * Add support for EVAL_RO (#1862) * add sort_ro * mark test as onlynon cluster * delete mark test as onlynoncluster * add eval_ro * fix linters * delete sort_ro * fix pr comment * add type hints * add type hints * linters * Add support for EVALSHA_RO (#1863) * add evalsha-ro * fix pr comment * add type hints * add type hints * Fix naming conventions (#1872) * fix naming convention * fix worng changes * change ports to resolve conflict with unstable_cluster Co-authored-by: Chayim I. Kirshen <c@kirshen.com> Co-authored-by: Chayim <chayim@users.noreply.github.com> Co-authored-by: Bar Shaul <88437685+barshaul@users.noreply.github.com> Co-authored-by: Varun Chopra <v@chopraaa.com> (cherry picked from commit 0d26117)

dvora-h and others added 3 commits January 3, 2022 19:44

add bzmpop

599fba7

add comment

3374ed2

Merge branch 'redis:master' into add-bzmpop

a614caf

dvora-h requested a review from chayim January 4, 2022 10:53

dvora-h added the feature New feature label Jan 4, 2022

chayim suggested changes Jan 12, 2022

View reviewed changes

dvora-h added 2 commits January 12, 2022 16:16

fix pr comment

97f86f9

fix linters

0783f05

dvora-h requested a review from chayim January 13, 2022 12:37

chayim added the redis-7 label Jan 16, 2022

chayim reviewed Jan 24, 2022

View reviewed changes

fix pr comments

dbc342c

dvora-h requested a review from chayim January 25, 2022 13:51

chayim approved these changes Jan 27, 2022

View reviewed changes

dvora-h merged commit c3c0b0b into redis:master Feb 2, 2022

dvora-h deleted the add-bzmpop branch February 2, 2022 10:49

dvora-h added a commit to dvora-h/redis-py that referenced this pull request Feb 2, 2022

Add support for BZMPOP (redis#1851)

d4fa099

* add bzmpop * add comment * fix pr comment * fix linters * fix pr comments

dvora-h added a commit to dvora-h/redis-py that referenced this pull request Feb 2, 2022

Add support for BZMPOP (redis#1851)

68c0bd1

* add bzmpop * add comment * fix pr comment * fix linters * fix pr comments

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for BZMPOP #1851

Add support for BZMPOP #1851

dvora-h commented Jan 4, 2022

chayim left a comment

codecov-commenter commented Jan 12, 2022 •

edited

Loading

chayim Jan 24, 2022

chayim Jan 24, 2022

chayim Jan 24, 2022

dvora-h Jan 25, 2022

Add support for BZMPOP #1851

Add support for BZMPOP #1851

Conversation

dvora-h commented Jan 4, 2022

Pull Request check-list

Description of change

chayim left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jan 12, 2022 • edited Loading

Codecov Report

chayim Jan 24, 2022

Choose a reason for hiding this comment

chayim Jan 24, 2022

Choose a reason for hiding this comment

chayim Jan 24, 2022

Choose a reason for hiding this comment

dvora-h Jan 25, 2022

Choose a reason for hiding this comment

codecov-commenter commented Jan 12, 2022 •

edited

Loading