-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search-json examples #1886
Add search-json examples #1886
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1886 +/- ##
==========================================
- Coverage 92.98% 92.95% -0.03%
==========================================
Files 76 76
Lines 16387 16389 +2
==========================================
- Hits 15237 15235 -2
- Misses 1150 1154 +4
Continue to review full report at Codecov.
|
"\n", | ||
"\n", | ||
"r = redis.Redis(host='localhost', port=36379)\n", | ||
"r.flushall()\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking - one doesn't have to flush their redis prior to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add en example for updating a document and running queries? Can we also add some query aggregations (see tests)?
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.