Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search-json examples #1886

Merged
merged 3 commits into from
Jan 19, 2022
Merged

Add search-json examples #1886

merged 3 commits into from
Jan 19, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Jan 18, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@dvora-h dvora-h requested a review from chayim January 18, 2022 15:52
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #1886 (5f8956b) into master (f0c0ab2) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1886      +/-   ##
==========================================
- Coverage   92.98%   92.95%   -0.03%     
==========================================
  Files          76       76              
  Lines       16387    16389       +2     
==========================================
- Hits        15237    15235       -2     
- Misses       1150     1154       +4     
Impacted Files Coverage Δ
tests/test_cluster.py 98.03% <0.00%> (-0.26%) ⬇️
redis/sentinel.py 86.16% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0c0ab2...5f8956b. Read the comment docs.

"\n",
"\n",
"r = redis.Redis(host='localhost', port=36379)\n",
"r.flushall()\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking - one doesn't have to flush their redis prior to use.

Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add en example for updating a document and running queries? Can we also add some query aggregations (see tests)?

@chayim chayim merged commit afaa1c8 into redis:master Jan 19, 2022
@dvora-h dvora-h deleted the search-json-examples branch January 25, 2022 11:55
dvora-h added a commit to dvora-h/redis-py that referenced this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants