Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds doctest examples for the hash tutorial #2821

Merged
merged 7 commits into from
Jul 4, 2023

Conversation

sav-norem
Copy link

creating the python hash data type examples that will be used in conjunction with the hashes.md file in docs to show tabbed examples

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.
Adding the python examples to be used in tabbed examples for the hash datatype.

sav-norem and others added 2 commits June 29, 2023 14:16
creating the python hash data type examples that will be used in conjunction with the hashes.md file in docs to show tabbed examples
@elena-kolevska elena-kolevska changed the title Create dt_hash.py Adds doctest examples for the hash tutorial Jun 29, 2023
@elena-kolevska
Copy link

@uglide please review and merge when you get the chace

doctests/dt_hash.py Outdated Show resolved Hide resolved
@elena-kolevska
Copy link

@uglide I just added the changes. Can we merge pls?

@uglide uglide merged commit 2bed636 into redis:emb-examples Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants