Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PythonRespSerializer: better chunking #3076

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

PythonRespSerializer: better chunking #3076

wants to merge 3 commits into from

Commits on Dec 17, 2023

  1. async: generalize packing + hiredis support 

    asyncio connection is pretty much the copy of normal redis connection,
so let's port hiredis support and also start using PythonRespSerializer.
    @VadimPushtaev
    VadimPushtaev committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    8a43014 View commit details
    Browse the repository at this point in the history

  2. tests: unit tests for PythonRespSerializer 

    We lack detailed tests for PythonRespSerializer, so let's add them.
The current behaviour is weird and will be changed by the following
commit, but the tests are still needed to explicitly show the change.
    @VadimPushtaev
    VadimPushtaev committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    715bc06 View commit details
    Browse the repository at this point in the history

  3. PythonRespSerializer: better chunking 

    Previous implementation made no difference between memoryviews, that must
be sent separately to avoid copying, and just reaching buffer_cutoff.
That resulted in some single values being sent separately for no reason,
so a chunk could be just a single encoded integer, even though the
buffer_cutoff is pretty large.
    @VadimPushtaev
    VadimPushtaev committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    8b431e9 View commit details
    Browse the repository at this point in the history