Fix distributed db ring collision #354
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g CRCs (or the same node twice)
|
There might be a better place to put the test for the introduced code, but I have not found the file for the HashRing tests. |
|
Any progress on this? |
djanowski
pushed a commit
that referenced
this pull request
Nov 16, 2015
…g CRCs (or the same node twice) See #354
djanowski
added a commit
that referenced
this pull request
Nov 16, 2015
|
Sorry for the delay. Thank you. |
|
This is available in 3.2.2. |
|
lolk, your are welcome :) |
oleksandrbyk
added a commit
to oleksandrbyk/olek-ruby-redis
that referenced
this pull request
Feb 6, 2019
…g CRCs (or the same node twice) See redis/redis-rb#354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a test to the HashRing#add_node that will test if a node ID's CRC checksum is already present and will throw an exception in such a case.
This enables to prevent quiet CRC collisions and adding databases which have the same ID, but are not identical. I had this error when adding multiple MockRedis objects to the ring which had the same ID.