Implement bitpos command. #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command landed in unstable today. Tests are taken and translated from the original Tcl test suite.
| synchronize do |client| | ||
| command = [:bitpos, key, bit] | ||
| command << start if start | ||
| command << stop if stop |
There was a problem hiding this comment.
If start is not specified, the value given for stop will be injected into start's position; it would be wise to safeguard against this:
Consider:
# attempt to get first 3 bytes
redis.bitpos('foo',0,nil,3)
# intent: BITPOS foo 0 0 3
# actual: BITPOS foo 0 3
# actually get bytes after 3rd byteMaybe something like this:
def bitpos(key, bit, start=nil, stop=nil)
if stop and not start
raise(ArgumentError, 'stop parameter specified without start parameter')
end
# ...
endThere was a problem hiding this comment.
Good idea, will fix it that way.
If start is not specified, the value given for stop will be injected into start's position; it is wise to safeguard against this. (via @yaauie)
|
Somehow the redis instance for testing died in between, that's why the test is failing. Could someone with access rights re-trigger that build? (or give me access rights, cough cough) |
|
I restarted the offending job & will check back on it later. |
|
Great! :) |
|
This feature was released in 3.1.0; thanks for your contribution 👍 |
|
Yippieh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command landed in unstable today.
Tests are taken and translated from the original Tcl test suite.