Makes setting scope fully optional in session managers #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerhutcherson
force-pushed
the
feat/RAAE-191/scopeless-sessions
branch
from
92619dd to
0044981
Compare
|
inside search_cache() what if instead of: |
tylerhutcherson
approved these changes
Jul 31, 2024
| user_tag: Optional[str] = None, | ||
| as_text: bool = False, | ||
| raw: bool = False, | ||
| tag_filter: Optional[FilterExpression] = None, |
There was a problem hiding this comment.
my concern here is we blur the conceptual lines between a tag_filter and a session_tag. Also we "own" the schema. Users wouldn't know they are supposed to use this field for session filtering. Ideally we make it so it's super clear :)
We could make it clear and ask them to pass the session_tag: Optional[str] = None here and WE wrap it into a Tag filter since we own the schema and know how to apply it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the requirement that user and session tags be specified on session manager initialization. Session tags can be added when storing messages and filter expressions can be used to retrieve specific chat histories. A default uuid is used when no session is provided.