Skip to content

[WIP] rueidiscompat continue #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 20, 2022
Merged

[WIP] rueidiscompat continue #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
71ab95f
feat: remove unnecessary cmds recycling in rueidiscompat
rueian Apr 19, 2022
29d9d31
feat: make Cmd constructors in rueidiscompat be private
rueian Apr 19, 2022
18a73fb
feat: remove baseCmd in rueidiscompat
rueian Apr 19, 2022
c8cb2fd
feat: remove partial cmd type assertions in rueidiscompat
rueian Apr 19, 2022
ea62eef
feat: remove unused ttl field in rueidiscompat.Compat
rueian Apr 19, 2022
8f2e99e
test: add test case for AsBool
rueian Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions message.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,9 +286,7 @@ func (m *RedisMessage) AsInt64() (val int64, err error) {

// AsBool checks if message is non-nil redis response, and parses it as bool
func (m *RedisMessage) AsBool() (val bool, err error) {
val = false
err = m.Error()
if err != nil {
if err = m.Error(); err != nil {
return
}
switch m.typ {
Expand Down
34 changes: 34 additions & 0 deletions message_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,27 @@ func TestRedisResult(t *testing.T) {
}
})

t.Run("AsBool", func(t *testing.T) {
if _, err := (RedisResult{err: errors.New("other")}).AsBool(); err == nil {
t.Fatal("ToBool not failed as expected")
}
if _, err := (RedisResult{val: RedisMessage{typ: '-'}}).AsBool(); err == nil {
t.Fatal("ToBool not failed as expected")
}
if v, _ := (RedisResult{val: RedisMessage{typ: '#', integer: 1}}).AsBool(); !v {
t.Fatal("ToBool not get value as expected")
}
if v, _ := (RedisResult{val: RedisMessage{typ: ':', integer: 1}}).AsBool(); !v {
t.Fatal("ToBool not get value as expected")
}
if v, _ := (RedisResult{val: RedisMessage{typ: '+', string: "OK"}}).AsBool(); !v {
t.Fatal("ToBool not get value as expected")
}
if v, _ := (RedisResult{val: RedisMessage{typ: '$', string: "OK"}}).AsBool(); !v {
t.Fatal("ToBool not get value as expected")
}
})

t.Run("ToFloat64", func(t *testing.T) {
if _, err := (RedisResult{err: errors.New("other")}).ToFloat64(); err == nil {
t.Fatal("ToFloat64 not failed as expected")
Expand Down Expand Up @@ -237,6 +258,19 @@ func TestRedisMessage(t *testing.T) {
(&RedisMessage{typ: 't'}).ToBool()
})

t.Run("AsBool", func(t *testing.T) {
if _, err := (&RedisMessage{typ: '_'}).AsBool(); err == nil {
t.Fatal("AsBool not failed as expected")
}

defer func() {
if !strings.Contains(recover().(string), "redis message type t is not a int, string or bool") {
t.Fatal("AsBool not panic as expected")
}
}()
(&RedisMessage{typ: 't'}).AsBool()
})

t.Run("ToFloat64", func(t *testing.T) {
if _, err := (&RedisMessage{typ: '_'}).ToFloat64(); err == nil {
t.Fatal("ToFloat64 not failed as expected")
Expand Down
Loading