Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions publish #58

Closed
ayr-ton opened this issue Feb 22, 2022 · 6 comments
Closed

GitHub Actions publish #58

ayr-ton opened this issue Feb 22, 2022 · 6 comments

Comments

@ayr-ton
Copy link
Contributor

ayr-ton commented Feb 22, 2022

What about a GitHub Action that publishes the Docker container to the GitHub repository registry?

@rednafi
Copy link
Owner

rednafi commented Feb 22, 2022

This is a great idea but I'm not sure how it'd be helpful when you'll need access to the code.

@ayr-ton
Copy link
Contributor Author

ayr-ton commented Feb 22, 2022

@rednafi Access to the code how? Could you elaborate?

@rednafi
Copy link
Owner

rednafi commented Feb 22, 2022

@ayr-ton This application is pretty basic at what it does. However, it's extensible. So, if I push this as a container, what purpose that'd serve? I mean in the end, you'll need access to the code in the container and if you docker-pull the container, you won't have access to the source code.

I mean, it's easy enough to push the container but I was wondering what purpose that'd serve.

@ayr-ton
Copy link
Contributor Author

ayr-ton commented Feb 22, 2022

@rednafi Got it!
I think in 2 advantages:

  • Testing the container build itself (we could actually test it with testinfra for validating aspects of the container creation)
  • Have a reference pipeline on how to push the container to a registry (either GitHub or https://ttl.sh/)

Also, we could publish it to dockerhub if we want so anyone could pull the image for validating the working architecture.

If someone chooses to use some container scheduler in the future, this someone would just need to track the container registry for having updates (Ex.: ArgoCD).

@rednafi
Copy link
Owner

rednafi commented Feb 22, 2022

I think you've convinced me. So, what I'll do is to push the container to GitHub registry and then see if anyone finds that useful. Thank you.

rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
rednafi added a commit that referenced this issue Feb 24, 2022
@rednafi
Copy link
Owner

rednafi commented Feb 25, 2022

After battling with the CI, this is now ready. Checkout the release for details. Thank you.

@rednafi rednafi closed this as completed Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants