Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multi-root Workspaces #37

Open
IgorKarpiuk opened this issue Aug 15, 2022 · 4 comments
Open

Handle multi-root Workspaces #37

IgorKarpiuk opened this issue Aug 15, 2022 · 4 comments

Comments

@IgorKarpiuk
Copy link

What should we improve?

Users can have several projects in vs code workspace . Each project can have its own configuration file. The goal is to find the correct configuration depending on the file selected by the user and highlight errors and warnings in OpenAPI definition files according to the configuration

How should we improve it?

The extension should select the root folder and look for the configuration file there depending on the file opened by the user

Why should we improve it?

Currently, the extension does not work correctly with Multi-root Workspaces

Describe alternatives you've considered

To do nothing

Additional context

Multi-root Workspaces

@unional
Copy link

unional commented Sep 25, 2023

Just sharing that I also have the same need.

@tatomyr tatomyr added p2 and removed p3 labels Sep 27, 2023
@jeremyfiel
Copy link

Would be great to have this functionality! @lornajane

@adamaltman
Copy link
Member

Does the apis feature of the config file, where you can specify different paths to the root files serve as an alternative?

apis:
  example1: 
     root: ./path/to/file.yaml
     rules:
       # some rules
  example2: 
     root: ./path/to/file.yaml
     rules:
       # some rules

@IgorKarpiuk
Copy link
Author

IgorKarpiuk commented Dec 22, 2023

@adamaltman I think it does not. Because we always select the configuration file from the root of the first workspace. if the order of the workspaces is changed or the user closes the workspace with the configuration file, it will stop working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants