[v22.3.x] c/partition_allocator: make _highest_group updates monotonic
#14466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, in case of failed allocation of partitions for new topics, we tried to revert _highest_group value as well. When a large number of topics were allocated in a single request concurrently (e.g. when MirrorMaker creates required topics on the destination cluster) and some of these requests bump into partition allocation limits, this could lead to duplicate group_ids. As there is no reason to try to reuse group_ids, simply remove the code moving _highest_group backwards. Fixes redpanda-data#12610 (cherry picked from commit 3f96297) Conflicts: src/v/cluster/scheduling/allocation_state.cc src/v/cluster/scheduling/partition_allocator.h
bharathv
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #14375