[v23.2.x] Fixed handling Raft snapshot #14981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When writing snapshot Raft gate should be held. This will prevent interrupting snapshot creation in the middle of write process. Fixes: redpanda-data#14896 Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 8e595aa)
When state machine is applying the snapshot it may be the case that another install snapshot request is received by underlying Raft protocol instance. In this case the STM should immediately proceed to applying the new snapshot instead of trying to read log from an offset which is lower than the new log start offset. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 78d2b21)
piyushredpanda
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #14929
Fixes: #14980,