Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk: list all partitions, including disabled #15098

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

r-vasquez
Copy link
Contributor

Redpanda's admin API interprets the absence of the 'disabled' query parameter differently from when its value is set to false.

If it's absent, it will list all partitions, including disabled.

EXAMPLES:

# All:
$ rpk cluster partitions list -a 
NAMESPACE       TOPIC               PARTITION  LEADER-ID  REPLICA-CORE   DISABLED
kafka           __consumer_offsets  0          -          [0-5 1-6 2-5]  false
kafka           __consumer_offsets  1          -          [0-6 1-7 2-6]  false
kafka           __consumer_offsets  2          -          [0-7 1-8 2-7]  false
kafka           bar                 0          -          [0-1 1-2 2-1]  false
kafka           bar                 1          -          [0-2 1-3 2-2]  true   <--- #disabled included
kafka           bar                 2          -          [0-3 1-4 2-3]  false
kafka           foo                 0          -          [1-1]          false
kafka_internal  id_allocator        0          -          [0-4 1-5 2-4]  false

# Disabled only 
$ rpk cluster partitions list -a --disabled-only 
NAMESPACE  TOPIC  PARTITION  LEADER-ID  REPLICA-CORE   DISABLED
kafka      bar    1          -          [0-2 1-3 2-2]  true

# Per-topic
$ rpk cluster partitions list bar               
NAMESPACE  TOPIC  PARTITION  LEADER-ID  REPLICA-CORE   DISABLED
kafka      bar    0          -          [0-1 1-2 2-1]  false
kafka      bar    1          -          [0-2 1-3 2-2]  true   <--- #disabled included
kafka      bar    2          -          [0-3 1-4 2-3]  false

# Per-topic, disabled only
$ rpk cluster partitions list bar --disabled-only 
NAMESPACE  TOPIC  PARTITION  LEADER-ID  REPLICA-CORE   DISABLED
kafka      bar    1          -          [0-2 1-3 2-2]  true

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.2.x
  • v23.1.x
  • v22.3.x

Release Notes

  • none

Redpanda's admin API interprets the absence of the
'disabled' query parameter differently from when
its value is set to false.

If it's absent, it will list _all_ partitions,
including disabled.
@vbotbuildovich
Copy link
Collaborator

@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/41599#018bf86a-8e42-4de8-979f-d85a6e9e962a:

"rptest.tests.topic_delete_test.TopicDeleteCloudStorageTest.topic_delete_cloud_storage_test.disable_delete=False.cloud_storage_type=CloudStorageType.ABS"

@r-vasquez
Copy link
Contributor Author

@twmb twmb merged commit 6665655 into redpanda-data:dev Nov 22, 2023
23 of 25 checks passed
@twmb twmb deleted the list-fix branch November 27, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants