rpk debug bundle: k8s bundle improvements #15185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now you can pass --label-selector/l to filter resources by label in the k8s-oriented bundle.
If we are unable to get the admin API endpoints from calling the k8s API (e.g permissions issues) then we use the localhost and try to get what we can from there.
twmb
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a63bf66 adds a new flag
--label-selectortorpk debug bundleand have a way to filter the bundled resources by label, by default this is the labelapp.kubernetes.io/name: redpanda. Fixes Limitrpk debugto gather pod detail for specific redpanda labels #14362444f2dc makes rpk fall back to localhost in the case that we are not able to get the admin API addresses by calling the k8s API. Fixes https://github.com/redpanda-data/core-internal/issues/925
6ed92b5 adds a new field
size_bytesto the generateddata_dir.txtfile.Backports Required
Release Notes
Features
--label-selectortorpk debug bundleand have a way to filter the bundled resources by label.