Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.3.x] Introduce wasm::logger #16195

Merged
merged 3 commits into from
Jan 21, 2024
Merged

[v23.3.x] Introduce wasm::logger #16195

merged 3 commits into from
Jan 21, 2024

Conversation

oleiman
Copy link
Member

@oleiman oleiman commented Jan 19, 2024

Backport of PR #16153

@oleiman
wasm: Introduce wasm::logger
e6bafd5 
Introduces abstract wasm::logger base class exposing a virtual interface
for logging.

Future implementations will encapsulate higher level log management facilities.

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit 0104afe)
@oleiman oleiman added this to the v23.3.x-next milestone Jan 19, 2024
@oleiman oleiman added the kind/backport PRs targeting a stable branch label Jan 19, 2024
@oleiman oleiman requested a review from rockwotj January 19, 2024 22:52
@oleiman oleiman self-assigned this Jan 19, 2024
@oleiman oleiman marked this pull request as ready for review January 19, 2024 22:52
@oleiman
Copy link
Member Author

oleiman commented Jan 19, 2024

/dt

@oleiman
transform: Introduce transform::logger
592791b 
Encapsulates a transform name and a ss::logger.

Writes to broker logs for now, but in future will:

- Handle line buffering
- Forward log lines to a higher level log management facility

(cherry picked from commit 4f69748)
@oleiman
transform: Wire up wasm::logger
16a59cf 
The main change here is that, rather than initializing factories
with a `ss::logger*`, we'll initialize _engines_ with an owning
`wasm::logger` reference. The rest is just plumbing.

Also introduces some thin loggers for testing purposes and updates
`transform::service` with `transform::logger`.

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit d192d01)
@oleiman oleiman force-pushed the vbotbuildovich/backport-16153-v23.3.x-927 branch from bf4b833 to 16a59cf Compare January 19, 2024 23:34
@oleiman
Copy link
Member Author

oleiman commented Jan 19, 2024 •
edited
Loading

force push new file had a wrong header path

@oleiman oleiman changed the title [v23.3.x] Introduce [v23.3.x] Introduce wasm::logger Jan 19, 2024
@oleiman
Copy link
Member Author

oleiman commented Jan 20, 2024

CI Failures:

rockwotj
rockwotj approved these changes Jan 20, 2024
View reviewed changes
Copy link
Contributor

@rockwotj rockwotj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, why did auto backport fail?

@oleiman
Copy link
Member Author

oleiman commented Jan 21, 2024

LGTM, why did auto backport fail?

Includes. Some of the base/*, strings library stuff and the like.

@oleiman oleiman merged commit 703e3f8 into redpanda-data:v23.3.x Jan 21, 2024
18 checks passed
@github-actions github-actions bot mentioned this pull request Jan 29, 2024
Merged
@oleiman oleiman mentioned this pull request Jan 30, 2024
Closed
@piyushredpanda piyushredpanda modified the milestones: v23.3.x-next, v23.3.6 Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockwotj rockwotj rockwotj approved these changes

Assignees

@oleiman oleiman

Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v23.3.6
Development

Successfully merging this pull request may close these issues.
3 participants
@oleiman @rockwotj @piyushredpanda