[v23.3.x] Enable large alloc warnings above 128KiB by default #16844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have the reactor stall warnings on in "prod" and arguably the large allocs are more important as they actually might result in a crash. Further the large alloc threshold automatically increases after each warning so it's unlikely for this to be very spamy. (cherry picked from commit 2be51c0)
Remove the passing of the large alloc warning threshold in DT. We now set it to 128KiB by default in the binary so we don't want to override it 256KiB in DT. Note this doesn't affect the actual BadLogLines check as that has a separate limit of 400KiB for marking log lines as hard failures. (cherry picked from commit a9003cc)
piyushredpanda
approved these changes
Mar 2, 2024
This was referenced Mar 13, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #16828