Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap certain wasm32-wasi ABI unsafe calls in unsafe to fix the build. #18307

Merged
merged 2 commits into from
May 14, 2024

Conversation

voutilad
Copy link
Contributor

@voutilad voutilad commented May 8, 2024

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

n/a

Bug Fixes

  • Unbreak building sr-sys crate for wasm32-wasi target

Features

n/a

Improvements

n/a

@github-actions github-actions bot added the area/wasm WASM Data Transforms label May 8, 2024
@voutilad
Copy link
Contributor Author

voutilad commented May 9, 2024

I modified the PR to mark the ABI stubs as unsafe, otherwise the Rust compiler will warn about unnecessary unsafe usage when building on a non-wasm32 target.

@voutilad voutilad changed the title Wrap certain wasm32-wasi ABI unsafe calls in unsafe to fix the build. Wrap certain wasm32-wasi ABI unsafe calls in unsafe to fix the build. May 9, 2024
@rockwotj
Copy link
Contributor

Should probably prioritize an integration test for SR + Rust:

SCHEMA_REGISTRY: "@UNIMPLEMENTED@"

@voutilad voutilad requested review from a team and BenPope and removed request for a team May 14, 2024 12:57
@michael-redpanda
Copy link
Contributor

Should probably prioritize an integration test for SR + Rust:

SCHEMA_REGISTRY: "@UNIMPLEMENTED@"

@oleiman -> can you file an issue for this please? Thanks

@oleiman
Copy link
Member

oleiman commented May 14, 2024

Should probably prioritize an integration test for SR + Rust:

SCHEMA_REGISTRY: "@UNIMPLEMENTED@"

@oleiman -> can you file an issue for this please? Thanks

Yup, will do.

@michael-redpanda michael-redpanda merged commit 31705d2 into redpanda-data:dev May 14, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/wasm WASM Data Transforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants