storage/tests: Adjust step size deviation used in test #18420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the e2e storage test the index step size of 32KiB is used as possible deviance from expected results. An allowance of 50KiB is used to prevent the test failing because of index step size. The change computes max step size across all segment indices and uses that as the deviance.
abhijat
changed the title
Lazin
approved these changes
May 13, 2024
Lazin
reviewed
May 13, 2024
| auto& pos = _index._state.position_index; | ||
| diffs.reserve(pos.size()); | ||
| std::adjacent_difference( | ||
| pos.begin(), pos.end(), std::back_inserter(diffs)); |
There was a problem hiding this comment.
didn't know about adjacent_difference, cool
There was a problem hiding this comment.
Unfortunately it does not work on const references to containers, but handy where usable.
|
Known failure: #13275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the e2e storage test the index step size of 32KiB is used as possible deviation from expected results. An allowance of 50KiB is used to prevent the test failing because of index step size.
The change computes max step size across all segment indices and uses that as the deviation.
FIXES #18396
Backports Required
Release Notes