Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v23.1.x] admin: move /redpanda-services to /debug #9659

Merged
merged 3 commits into from
Mar 27, 2023

Conversation

NyaliaLui
Copy link
Contributor

@NyaliaLui NyaliaLui commented Mar 24, 2023

Cover letter

Backport of PR #9631

Fixes: #9658

UX Changes

  • Changes the pathing to restart the Schema Registry on the Admin API from PUT /v1/redpanda-services/restart?service=schema-registry to PUT /v1/debug/restart_service?service=schema-registry.

Release Notes

Improvements

  • Changes the path for restarting a Redpanda Service via the Admin API. Previously users would issue PUT /v1//redpanda-services/restart?service=schema-registry, now users issue PUT /v1/debug/restart_service?service=schema-registry

The restart-services endpoint is mainly for internal use, so let's move
it to /debug.

Fixes: redpanda-data#9279
(cherry picked from commit a3b488a)
Schema Registry restart already has a success test in
schema_registry_test.py so there is no need to test it twice.

(cherry picked from commit e912ab7)
@NyaliaLui
Copy link
Contributor Author

/ci-repeat 10
dt-repeat=100
tests/rptest/tests/restart_services_test.py tests/rptest/tests/schema_registry_test.py::SchemaRegistryTest.test_restart_schema_registry

1 similar comment
@NyaliaLui
Copy link
Contributor Author

/ci-repeat 10
dt-repeat=100
tests/rptest/tests/restart_services_test.py tests/rptest/tests/schema_registry_test.py::SchemaRegistryTest.test_restart_schema_registry

Copy link
Contributor

@michael-redpanda michael-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NyaliaLui NyaliaLui merged commit 8690727 into redpanda-data:v23.1.x Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants