Skip to content

More test coverage #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 11, 2019
Merged

More test coverage #4

merged 9 commits into from
Oct 11, 2019

Conversation

karlnorling
Copy link
Contributor

@karlnorling karlnorling commented Sep 16, 2019

Adding some more tests.

Screenshot 2019-09-16 at 21 25 42

@cv711
Copy link
Contributor

cv711 commented Sep 19, 2019

Why don't we run all those tests during CI builds?

@karlnorling
Copy link
Contributor Author

@cv711 I had issues with downloading and building capnp in circle ci. One have to build it from source and a special version for node 8. And then install the npm capnp lib.

@cv711
Copy link
Contributor

cv711 commented Sep 19, 2019

@karlnorling we could run the tests inside the sandbox container we are building no?

@karlnorling karlnorling force-pushed the more-tests branch 5 times, most recently from e1c49ca to c05d168 Compare September 30, 2019 11:37
@karlnorling
Copy link
Contributor Author

@cv711 this is a lot more work than I thought - and I'm not sure if updating the baseexec docker image does changes to the built docker image later. I'm also having issues compiling cap'nproto on the alpine distro - it's missing a fair amount of different things.

          echo Installing Capn'Proto for node 8
          apk --no-cache add openssl wget
          apk add build-base
          curl -O https://capnproto.org/capnproto-c++-0.6.1.tar.gz
          tar zxf capnproto-c++-0.6.1.tar.gz
          cd capnproto-c++-0.6.1
          ./configure
          make -j6 check
          sudo make install

Right now it's failing on make -j6 check

libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I./src -I./src -DKJ_HEADER_WARNINGS -DCAPNP_HEADER_WARNINGS "-DCAPNP_INCLUDE_DIR=\"/usr/local/include\"" -O2 -DNDEBUG -MT src/kj/mutex.lo -MD -MP -MF src/kj/.deps/mutex.Tpo -c src/kj/mutex.c++  -fPIC -DPIC -o src/kj/.libs/mutex.o
src/kj/mutex.c++:34:25: fatal error: linux/futex.h: No such file or directory
 #include <linux/futex.h>

And I have no idea how to install futex kernel tool on alpine distro.

@karlnorling karlnorling force-pushed the more-tests branch 3 times, most recently from 401f557 to 0f5d860 Compare October 1, 2019 13:40
@karlnorling karlnorling force-pushed the more-tests branch 11 times, most recently from 787bbad to 15ca37a Compare October 1, 2019 15:46
@karlnorling karlnorling merged commit e6c6955 into master Oct 11, 2019
@karlnorling karlnorling deleted the more-tests branch October 11, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants