-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.4.8 throws PropTypes validation warnings for React 14 #669
Comments
@gaearon So, is |
I have this problem too. |
Okay, this one is hard.. Let me think on it. |
The problem is technically those warnings were introduced in React 15. And But in this case they’re not actionable because they’re coming from React itself. 😞 |
I am looking at the stack to see if we're plausibly calling from React 0.14, and opting into the old behavior in this case. I'm sorry for doing this. Fixes reduxjs/react-redux#669
I'm going to try to cut |
Okay, |
I also cut |
For every component we use 'connect' in, we get the following JS warning on every render:
Right now, each page load brings about 2000 of these warnings.
For example, using the following component throws warnings:
But simply removing the 'connect' usage "fixes" the problem (although it renders the component useless):
I confirmed that downgrading to 4.4.7 makes the issue go away.
We are using React 0.14.8
The text was updated successfully, but these errors were encountered: