Correct ownProps note and examples
#420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ```javascript | ||
| function mapStateToProps() { | ||
| console.log(arguments[0]); // state | ||
| function mapDispatchToProps(state) { |
There was a problem hiding this comment.
I think it's worth to show that this is about mapDispatchToProps too, that's why I did it. You wish to have all examples consistent I guess?
There was a problem hiding this comment.
The confusing part is the argument is still named "state". I would probably just use mapStateToProps in both examples.
|
Thanks! |
foiseworth
pushed a commit
to foiseworth/react-redux
that referenced
this pull request
Jul 30, 2016
albertodev7
pushed a commit
to albertodev7/react-redux
that referenced
this pull request
Dec 8, 2022
Correct `ownProps` note and examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope it's true this time.