Fix module bundling & ESM runtime error #280
Conversation
|
Deploy preview for redux-starter-kit-docs ready! Built with commit 8ab6778 https://deploy-preview-280--redux-starter-kit-docs.netlify.com |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8ab6778:
|
| @@ -15,19 +15,26 @@ module.exports = { | |||
| case 'umd': | |||
| delete config.external | |||
| config.output.indent = false | |||
| config.plugins.push( | |||
| config.plugins.unshift( | |||
There was a problem hiding this comment.
The plugins were being called after TS compilation, and weren't behaving as desired. I've moved them to the front of the plugin pipeline so that the compiled code takes the modifications into account.
| replace({ | ||
| '// UMD-DEV-ONLY: ': '' | ||
| '// UMD-ONLY: ': '', | ||
| delimiters: ['', ''] |
There was a problem hiding this comment.
This replacement was never matching due to it being constrained to word boundaries as explained here.
| config.plugins.unshift( | ||
| stripCode({ | ||
| start_comment: 'PROD_START_REMOVE_UMD', | ||
| end_comment: 'PROD_STOP_REMOVE_UMD' |
There was a problem hiding this comment.
This replace instance allows for instantiation of redux-immutable-state-invariant in development builds only
|
Huh. Yeah, that actually looks like the UMD Dev build is currently broken. Thanks for fixing this! |
|
As reported in #297, the |
Closes #278
I've tested the ESM build locally and confirmed that I no longer see the original issue.
When building for production, the
if (process.env.NODE_ENV !== 'production') {is evaluated tofalseby Webpack and the chunk of code is omitted from output.The contents of the generated UMD file (
redux-toolkit.umd.min.js), hasn't changed, so there shouldn't be a problem there.However the development build has changed (screenshot attached below).
I believe this is because
redux-immutable-state-invariantwas not being instantiated before. I might be missing context here, but let me know if the old behaviour was correct and can fix the logic.