fix: UMD dev build by removing runtime usage of require statement #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for redux-starter-kit-docs ready! Built with commit 98593f9 https://deploy-preview-317--redux-starter-kit-docs.netlify.com |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 98593f9:
|
|
Yeah, diffing 1.2.1's UMD build vs the CSB build of this PR shows that we've removed the Thanks! I'll try to put out a new build this evening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #297
Thanks for your patience on this @phryneas.
I've simplified the build a little. Now it just uses the
PROD_START_REMOVE_UMDcomments throughout, and avoids a dynamicrequirestatement.The dev (unminified) UMD bundle is a few KB bigger, but the production one hasn't changed.