Skip to content

Conversation

i1skn
Copy link
Contributor

@i1skn i1skn commented Feb 22, 2021

@netlify
Copy link

netlify bot commented Feb 22, 2021

Deploy preview for redux-starter-kit-docs ready!

Built with commit 3b09ed5

https://deploy-preview-909--redux-starter-kit-docs.netlify.app

@markerikson
Copy link
Collaborator

Strictly speaking, we don't need to do anything on our end. Our own dependency says "anything 8.0.0 or newer", and 8.0.1 is already newer (ref: #871, #874, #879 , #890 ).

It's up to users to update the transitive dependencies locally, because their lockfiles have already settled on 8.0.0. And, any fresh installs of RTK will pick up 8.0.1 automatically.

But, I suppose it doesn't hurt to bump this here too.

@markerikson
Copy link
Collaborator

So this PR is actually bugged, because it didn't update our own lockfile too. Can you update the lockfile as well?

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3b09ed5:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration

@markerikson markerikson merged commit a25356b into reduxjs:master Feb 22, 2021
@markerikson
Copy link
Collaborator

Thanks. Will try to publish 1.5.1 later today or tomorrow, but as mentioned, you can resolve this on your end as well by just updating the transitive dependency yourself.

(Also, looking at the PR you linked: note that we recommend using createSlice as the default in most situations, rather than calling createAction directly, unless you really need to define standalone action types.)

@sleric1024
Copy link

Hi @markerikson , May I know that when will the 1.5.1 version be published ?
Thanks.

@markerikson
Copy link
Collaborator

markerikson commented Mar 10, 2021

Sorry, been busy and this has been a low priority.

As mentioned, strictly speaking we didn't even need to make this change - we already depended on anything in the 8.x range, so you just need to update your own installed packages to pick up the newer Immer version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants