Skip to content

resultEqualityCheck gets a WeakRef instead of derefed previous value. #750

@uncaught

Description

@uncaught

I don't know the exact circumstances, but I'm getting errors because resultEqualityCheck gets a WeakRef instead of the expected Set:

Image

Looks like the WeakRef is "cleared":

Image

So this line would still keep the WeakRef in lastResultValue:

const lastResultValue = lastResult?.deref?.() ?? lastResult

Should better be:

const lastResultValue = lastResult?.deref ? lastResult.deref() : lastResult

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions