Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Notices for vite storybook command #10747

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

Josh-Walker-GM
Copy link
Collaborator

This adds notices to inform users to try out the vite based storybook command.

@Josh-Walker-GM Josh-Walker-GM added release:feature This PR introduces a new feature changesets-ok Override the changesets check labels Jun 7, 2024
@Josh-Walker-GM Josh-Walker-GM added this to the next-release milestone Jun 7, 2024
@Josh-Walker-GM Josh-Walker-GM self-assigned this Jun 7, 2024
@Josh-Walker-GM Josh-Walker-GM requested a review from Tobbe June 7, 2024 13:33
if (getConfig().web.bundler === BundlerEnum.VITE) {
console.log(
c.bold(
`\nIt looks like you're using vite, please try:\n\n yarn rw storybook-vite\n\nThis will run storybook using vite which should be a much nicer experience for you.\nYou can find out more at: https://community.redwoodjs.com/t/7212\n\n`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great messaging 👍

Copy link
Member

@Tobbe Tobbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Josh-Walker-GM Josh-Walker-GM merged commit 9faa582 into main Jun 7, 2024
51 checks passed
@Josh-Walker-GM Josh-Walker-GM deleted the jgmw/storybook-vite-cli-notice branch June 7, 2024 18:17
Josh-Walker-GM added a commit that referenced this pull request Jun 9, 2024
This adds notices to inform users to try out the vite based storybook
command.
@Josh-Walker-GM Josh-Walker-GM modified the milestones: next-release, v7.7.0 Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:feature This PR introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants