Humanize labels on scaffold forms #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! Definitely an improvement, and no runtime weight added. Thanks! |
|
Love it, thanks! |
lachlanjc
added a commit
to lachlanjc/redwood
that referenced
this pull request
May 3, 2020
jmreidy
pushed a commit
to jmreidy/redwood
that referenced
this pull request
May 30, 2020
* Humanize labels on scaffold forms * Update snapshot
Tobbe
pushed a commit
to Tobbe/redwood
that referenced
this pull request
Jun 19, 2020
Tobbe
pushed a commit
to Tobbe/redwood
that referenced
this pull request
Jun 19, 2020
Tobbe
pushed a commit
to Tobbe/redwood
that referenced
this pull request
Jun 19, 2020
cannikin
pushed a commit
that referenced
this pull request
Jun 19, 2020
* Use CheckBox component for Boolean fields on scaffolded forms * Fix bug for Boolean-less forms * Update post-#493 * scaffold.js remove unnecessary computed property key * Fix component name * Fix component name in template * Update template * Prevent required on checkboxes * Update scaffold form * Switch to JS syntax * Less CheckBox-specific template * scaffold: Left-align checkbox Co-authored-by: Lachlan Campbell <lachlan@hackclub.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first code contribution to Redwood, so hoping I did this right!
Right now, when you generate scaffolding, the input labels are exactly the names of the database columns. If I were making a Pitchfork clone, it might have this:
I really like how Rails converts those names to more readable labels. Now, using humanize-string:
This adds a dependency to the CLI package, but we already have a number of string-converting libraries in use for scaffolding, & it doesn't add any weight to the app dependencies or the forms themselves.