Scaffolds use checkbox fields #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cannikin
approved these changes
Jun 19, 2020
Yes, I have. Works great! |
Tobbe
force-pushed
the
scaffolds-use-checkbox-fields-tobbe
branch
from
be8f8fd
to
a12b886
Compare
Tobbe
force-pushed
the
scaffolds-use-checkbox-fields-tobbe
branch
from
a12b886
to
4bd5886
Compare
|
By default the checkbox was centered, but I think it looks better to have it left-aligned. |
|
@cannikin I'm happy with this now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rebased all of @lachlanjc's commits in #495, and addressed @cannikin's comments.
I didn't do it exactly as Rob suggested, but I think the outcome is what we want.