Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE]: Plan for Event API #299

Closed
KaWaite opened this issue May 24, 2022 · 1 comment · Fixed by reearth/reearth-web#280
Closed

[FE]: Plan for Event API #299

KaWaite opened this issue May 24, 2022 · 1 comment · Fixed by reearth/reearth-web#280
Assignees
@airslice
Labels
frontend

Comments

@KaWaite
Copy link
Member

KaWaite commented May 24, 2022 •
edited
Loading

Plan out api changes for issue #298 .

Needs approval from @rot1024 before starting 298.
@KaWaite KaWaite mentioned this issue May 24, 2022
Closed
@KaWaite KaWaite self-assigned this May 24, 2022
@HideBa HideBa changed the title Plan for Event API [FE]: Plan for Event API May 25, 2022
@KaWaite KaWaite assigned airslice and unassigned KaWaite Jul 4, 2022
@airslice airslice mentioned this issue Jul 22, 2022
Merged
@airslice
Copy link
Contributor

From the previous conversiton i found the basic plan (from @rot1024) as:

  • Add a new method to the EngineRef type in Visualizer/Engine.
  • Visualizer/Engine/Cesium then exposes an implementation of that method.
  • In visualizer/Plugin, simply call that method when the plugin API is called.

pyshx pushed a commit that referenced this issue Apr 17, 2023
@airslice
fix: development error occurs when updating or DnD layers (#299)
efd0793 
* fix: attache tag when it already exists

* refactor: update condition order

* test: add unit test

* test: add test of remove property

* fix: attache tag when it already exists

* refactor: update condition order

* test: add unit test

* test: add test of remove property

* fix: develop error when dnd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@airslice airslice

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add mouse events to plugin API reearth/reearth-web
3 participants
@airslice @KaWaite @HideBa